fix(config): accept legacy dream/distill config keys with warning - #2229
fix(config): accept legacy dream/distill config keys with warning#2229rekty wants to merge 2 commits into
Conversation
Users setting \`enabled\`/\`intervalDays\` (camelCase) in dream/distill config sections get silently ignored because the schema only accepts \`auto\`/\`interval_days\`. Add pre-validation normalization that maps legacy keys to canonical names and logs a deprecation warning. Fixes XiaomiMiMo#2135
|
Hey! This PR fixes #2135 by adding normalization for legacy / config keys. Users setting or will now see a deprecation warning and the values get mapped to the canonical / keys. Ready for review! |
|
Hi! CI workflows (lint, test, typecheck) havent started yet — this is likely because GitHub requires first-time contributor approval for workflow runs. Could you please approve the CI runs on the Actions tab? Thanks! |
|
cc @MiMoHardFather @wqymi @yanyihan-xiaomi — could one of you approve the CI workflow runs for this fork PR? The lint/test/typecheck checks are waiting on approval. Thanks! |
|
Hi @MiMoHardFather @yanyihan-xiaomi @wqymi 👋 I've submitted 8 PRs fixing various issues on Windows and cross-platform compatibility. All PRs are ready for review but CI workflows haven't been triggered yet because they're from a fork. Could you please approve the workflow runs for these PRs? Here's a summary:
To approve workflow runs: go to any PR → Files changed tab → click Awaiting approval → Approve workflows to run. Happy to address any feedback! 🙏 |
Users setting `enabled`/`intervalDays` (camelCase) in dream/distill config sections get silently ignored because the schema only accepts `auto`/`interval_days`. Add pre-validation normalization that maps legacy keys to canonical names and logs a deprecation warning.
Fixes #2135
Issue / context (if applicable)
Type of change
Bug fix / New feature / Refactor / Documentation — keep the ones that apply and delete the rest.
What does this PR do?
Briefly describe the problem, what changed, and why this approach works.
How did you verify your code works?
What did you test, and how can a reviewer reproduce the result?
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist