-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Scale
to SingleAssetVault
#5652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7d9dffc
b17b167
a38d7bf
622ef6e
f374d5a
87a9558
b302670
76fd2e8
6c31556
c788564
ff48d67
2b75960
a484b6e
44b60fe
09190db
97e44c7
35671ff
65dce68
2047661
d365a2d
f0e83dc
e9354a2
6d5389f
cf2536b
5e92e5b
3d88043
3fe388a
7938612
97c4578
b288d24
93df6ce
1d7992b
8c8e027
d24632d
0d046da
d145666
37196b7
c9e4b4a
76c3cff
3689246
a763642
6893015
011c3c6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -483,6 +483,7 @@ TRANSACTION(ttVAULT_CREATE, 65, VaultCreate, Delegation::delegatable, ({ | |
{sfDomainID, soeOPTIONAL}, | ||
{sfWithdrawalPolicy, soeOPTIONAL}, | ||
{sfData, soeOPTIONAL}, | ||
{sfScale, soeOPTIONAL}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
})) | ||
|
||
/** This transaction updates a single asset vault. */ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can simplify or maybe just use combination of
towards_zero
rounding andstatic_cast
sincetruncate()
usage is limited.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if that would be an improvement, given the complexity of
operator rep()
. On the other hand,normalize()
is also quite complex. However with the current implementation we can guaranteenoexcept
and I am not sure how this would look like if we usedoperator rep()
I will add a comment about
noexcept
and leave it like this for now.