Fix performance on MacOS #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- expose via the CLI - add a new Builder and Remover struct to hold any other future things we might make configurable.
Most MacOS filesystems will be APFS these days, which appears to have a global lock around readdir that leads to thrashing when performing readdir concurrently from different threads. https://gregoryszorc.com/blog/2018/10/29/global-kernel-locks-in-apfs/
rbtcollins
force-pushed
the
rbt/darwin-performance
branch
from
1d21136 to
92a0f1a
Compare
XAMPPRocky
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most MacOS filesystems will be APFS these days, which appears to have a
global lock around readdir that leads to thrashing when performing
readdir concurrently from different threads.
https://gregoryszorc.com/blog/2018/10/29/global-kernel-locks-in-apfs/
This patch: