fix: install over serial

[ioqnq]

Pull Request Overview

This pull request fixes and simplifies the WIP of the serial install implementation.

TODO or Help Wanted

Needs proper error-handling:

tockloader-rs/tockloader-lib/src/command_impl/serial/install.rs

Lines 82 to 105 in 7491f8a

	// TODO: handle error properly
	// let (ver, header_len, whole_len) = parse_tbf_header_lengths(
	// &message[0..8]
	// .try_into()
	// .expect("Buffer length must be at least 8 bytes long."),
	// //TODO: select an appropriate error
	// )
	// .unwrap();
	// if header_len == 0 {
	// break; // No more apps
	// }
	let (_ver, _header_len, whole_len) = match parse_tbf_header_lengths(
	&message[0..8]
	.try_into()
	.expect("Buffer length must be at least 8 bytes long."),
	) {
	Ok((ver, header_len, whole_len)) if header_len != 0 => (ver, header_len, whole_len),
	_ => break, // No more apps
	};
	address += whole_len as u64;

Checks

Using Rust tooling

• Ran cargo fmt
• Ran cargo clippy
• Ran cargo test
• Ran cargo build

Features tested:

• info with probe-rs on microbit-v2

• info with serial on microbit-v2

• info with tockloader on microbit-v2

• list with probe-rs on microbit-v2

• list with serial on microbit-v2

• list with tockloader on microbit-v2

GitHub Issue

This pull request closes #48

[eva-cosma]

Is this ready for review?

[ioqnq]

Is this ready for review?

At the time I was told to create this draft PR in order for you to test for errors. The code in its current state should be functional but I'm still working on simplifying it.

[eva-cosma]

All good to start review @ioqnq ?