Make it possible to customize app URL in Jupyter widget #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not fully documented but I want to get this online so I can check that it works when the Jupyter base URL is nontrivial.
|
Ah, looks like the switch to webkit means that we'll have to update all of the test images ... |
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
- Coverage 55.48% 55.44% -0.04%
==========================================
Files 25 25
Lines 2781 2783 +2
==========================================
Hits 1543 1543
- Misses 1238 1240 +2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I think that this will help address WorldWideTelescope/wwt_kernel_data_relay#4.
Checklist