support adding multiple connectors to same source_kind, using templates #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschultink
commented
Sep 10, 2025
| variable "enabled_connectors_from_templates" { | ||
| type = map(object({ | ||
| template_id = string | ||
| })) |
Member
Author
There was a problem hiding this comment.
- alter connector "specs" to be more like true templates, and have each evaluated in isolation with a "scope" that's the content of this object??
- problem with that is that I believe Terraform erases/hides object properties not explicitly in variables definition of the module; so we can't have arbitrary content.
- might also make module structure pretty complicated, with connectors being invoked repeatedly
- have a map(string) that is "merged" over top whatever the spec for the template has by default?
- not sure this is enough
- undermines value, bc in several cases you won't re-use that much of the template and will have to re-write a bunch of it.
- explicit set of properties that can be overridden;
target_host,environment_variables,settings_to_provide, andrules_fileprobably enough ...example_api_requestswill remain problematic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
TODO:
salesforce_domain, which if you want mutliple salesforce instances, you'd need to pass in multiple times to create the "templates"; as it stands, multiple salesforce connector usages via templates will end up with the same salesforce domain.Change implications