better User-Agent string
#873
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @NoArgsConstructor(onConstructor_ = @Inject) | ||
| @Log | ||
| public class HealthCheckRequestHandler { | ||
|
|
There was a problem hiding this comment.
Since JAVA_SOURCE_CODE_VERSION is now public and used to build the User-Agent string, consider updating its Javadoc to indicate its intended external use.
Suggested change
| /** | |
| * The version of the Java source code. | |
| * This constant is used to build the User-Agent string and is intended for external use. | |
| */ |
| } | ||
|
|
||
| private String getProxyUserAgentString() { | ||
| //q: something better here? pass through the actual client's User-Agent value?? |
There was a problem hiding this comment.
[nitpick] Remove or clarify the commented question to avoid confusion; if it's a placeholder for future work, consider adding a TODO with clear context.
Suggested change
| //q: something better here? pass through the actual client's User-Agent value?? | |
| //TODO: Consider passing through the actual client's User-Agent value for better accuracy. |
|
|
||
| private String getProxyUserAgentString() { | ||
| //q: something better here? pass through the actual client's User-Agent value?? | ||
| return "Psoxy/" + HealthCheckRequestHandler.JAVA_SOURCE_CODE_VERSION + " (API Data Sanitization; Java/" + System.getProperty("java.version", "unknown") + ")"; |
Contributor
There was a problem hiding this comment.
probably this can be static; so no need to calculate this again and again for each request
jlorper
requested changes
Apr 25, 2025
| ComposedHttpRequestInitializer initializer = | ||
| ComposedHttpRequestInitializer.of(initializeWithCredentials, | ||
| new GzipedContentHttpRequestInitializer("Psoxy")); | ||
| new GzipedContentHttpRequestInitializer(getProxyUserAgentString())); |
Member
There was a problem hiding this comment.
I don't think this does anything at all, as is used as fallback
so presumably we are sending this instead always:
Also, should that class be Gzipped... with double P?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
User-Agentstring sent to API serversChange implications