S186 tenant api submodules integration #830
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperez-worklytics
approved these changes
Nov 1, 2024
| source = "git::https://github.com/worklytics/terraform-aws-worklytics/examples/create_psoxy_connections?ref=v0.1.0" | ||
|
|
||
| # TODO review this: using the 1st unique ID while testing is OK, but maybe we should define a | ||
| # an explicit variable for it |
Contributor
There was a problem hiding this comment.
Probably; and that variable by default could have caller_gcp_service_account_ids[0]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tenant API integration: just an example of submodules integration (tested and working). @eschultink thoughts on this? If you agree with this approach, there would still be a couple details left to implement:
initscript?Fixes
.
Features
Change implications