Skip to content

Conversation

@eschultink
Copy link
Member

WARNING: breaking change, needs to wait for next version that permits breaking changes (target 0.6.x)

Fixes

  • msft churn - use time_rotating instead of time_static wrapping a function call, as truncation done in the expression isn't sufficient enough to stop Terraform from thinking there's a change

Change implications

  • dependencies added/changed? yes, depends on 1.7.x
  • something important to note in future release notes? you MUST upgrade terraform to 1.7.x, as minimum

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Switches sample date generation from a monthly first-of-month time_static resource (built from a dynamic timestamp expression that caused churn) to a long-lived time_rotating resource to reduce unnecessary Terraform plan diffs. This introduces a controlled annual rotation and aligns with the stated breaking change requiring Terraform 1.7.x.

  • Replace time_static month_start with time_rotating example_timestamp (rotation_days = 365)
  • Update module input example_api_calls_sample_date to use the new rotating resource ID

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Base automatically changed from rc-v0.5.10 to main October 8, 2025 08:41
@eschultink eschultink changed the base branch from main to rc-v0.5.11 October 8, 2025 18:31
Base automatically changed from rc-v0.5.11 to main October 28, 2025 18:08
@eschultink eschultink changed the base branch from main to rc-v0.5.12 October 28, 2025 21:33
Base automatically changed from rc-v0.5.12 to main November 12, 2025 16:19
@eschultink eschultink changed the base branch from main to rc-v0.5.13 November 12, 2025 19:21
Base automatically changed from rc-v0.5.13 to main November 17, 2025 18:49
@eschultink eschultink changed the base branch from main to rc-v0.5.14 November 17, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants