Skip to content

FEDX-4075: Fixed enclosing_range calculation #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FEDX-4075: Fixed enclosing_range calculation #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/scip_visitor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ class ScipVisitor extends GeneralizingAstVisitor {
symbol: symbol,
symbolRoles: SymbolRole.Definition.value,
diagnostics: meta.diagnostics,
enclosingRange: _lineInfo.getRange(node.offset, node.end),
enclosingRange: _lineInfo.getRange(node.offset, node.length),
));
}
}
4 changes: 2 additions & 2 deletions lib/src/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ void display(String input, {DisplayLevel level = DisplayLevel.warn}) {
}

extension LineInfoExtension on LineInfo {
List<int> getRange(int offset, int nameLength) {
List<int> getRange(int offset, int length) {
final start = getLocation(offset);
final end = getLocation(offset + nameLength);
final end = getLocation(offset + length);

final res = [
start.lineNumber - 1,
Expand Down