Skip to content

Playground CLI: Make additional worker initialization lazy #2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

brandonpayton
Copy link
Member

Motivation for the change, related issues

When --experimentalMultiWorker is used, it takes noticeably longer to start Playground CLI.

Related to #2419

Implementation details

This PR makes the CLI server available before additional workers are done initializing. The hope is that this will allow users to access Playground CLI right away, while additional workers are still coming online.

Testing Instructions (or ideally a Blueprint)

TBD

@brandonpayton brandonpayton requested a review from a team July 24, 2025 21:01
@brandonpayton brandonpayton self-assigned this Jul 24, 2025
@brandonpayton brandonpayton added [Type] Bug An existing feature does not function as intended [Package][@wp-playground] CLI labels Jul 24, 2025
@brandonpayton
Copy link
Member Author

So far, it seems like zipping the /internal directory for use by secondary workers is taking too long and blocking the first worker. Even though we announce the server is available much faster, it doesn't respond to requests until it is done zipping /internal.

@brandonpayton
Copy link
Member Author

brandonpayton commented Jul 24, 2025

So far, it seems like zipping the /internal directory for use by secondary workers is taking too long and blocking the first worker. Even though we announce the server is available much faster, it doesn't respond to requests until it is done zipping /internal.

@adamziel maybe I can look at using a temp dir for /internal instead and see how that speeds things up. We want to do that anyway for /internal/shared, and maybe zipping /internal is most of the perceivable UX problem.

@adamziel
Copy link
Collaborator

Let's try that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package][@wp-playground] CLI [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants