Skip to content

HTML API: Use assertEqualHTML() in media tests. #9264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

dmsnell
Copy link
Member

@dmsnell dmsnell commented Jul 15, 2025

Trac ticket: Core-63694

Prep work for #9248.

dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jul 15, 2025
@dmsnell dmsnell force-pushed the html-api/tests-media branch from aa0cfea to 0db6cb5 Compare July 15, 2025 02:54
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@dmsnell dmsnell marked this pull request as ready for review July 15, 2025 16:03
Copy link

github-actions bot commented Jul 15, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dmsnell, jonsurrell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jul 15, 2025
@dmsnell dmsnell force-pushed the html-api/tests-media branch from 0db6cb5 to bbc07a3 Compare July 15, 2025 16:12
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement for the clarity of test output. The additional checks in this test are nice additions as well.

dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jul 18, 2025
@dmsnell dmsnell force-pushed the html-api/tests-media branch from bbc07a3 to 59d7197 Compare July 18, 2025 19:38
@dmsnell dmsnell force-pushed the html-api/tests-media branch from 59d7197 to b077057 Compare July 18, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants