HTML API: Coordination of wp_kses_hair() refactor.
#9256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
force-pushed
the
wp-kses-hair-fixes
branch
5 times, most recently
from
c5909df to
d18919f
Compare
Trac ticket: Core-63694 `wp_kses_hair()` is built around an impressive state machine for parsing the `$attr` of an HTML tag, that is, the span of text after the tag name and before the closing `>`. Unfortunately, that parsing code doesn’t fully-implement the HTML specification and may be prone to mis-parsing. This patch replaces the existing state machine with a straight-forward use of the HTML API to parse the attributes for us, constructing a shell take for the `$attr` string and reading the attributes structurally. This shell is necessary because a previous stage of the pipeline has already separated what it thinks is the so-called “attribute list” from a tag. Props: dmsnell
dmsnell
force-pushed
the
wp-kses-hair-fixes
branch
7 times, most recently
from
bf51620 to
cdcc474
Compare
Prep work for WordPress#9248 See also WordPress#9251
dmsnell
force-pushed
the
wp-kses-hair-fixes
branch
3 times, most recently
from
479a8f9 to
5c44635
Compare
dmsnell
force-pushed
the
wp-kses-hair-fixes
branch
3 times, most recently
from
3f0c2d7 to
91dd319
Compare
dmsnell
force-pushed
the
wp-kses-hair-fixes
branch
from
91dd319 to
c297fb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9248
This branch is collecting all of the various changes necessary to refactor
wp_kses_hair()to use the HTML API. It’s mainly for running tests and determining which tests are currently broken and need to be updated to prevent false negatives.