Repository navigation
Build/Test Tools: Add xfn.js, language-chooser.js, and sanitize.js to TypeScript checking - #16117
faisalahammad wants to merge 1 commit into
Conversation
…js` to TypeScript checking. These files already pass the existing strict TypeScript configuration, so no source changes are needed. See #66751.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
lancewillett
left a comment
There was a problem hiding this comment.
I verified that all three files enter the compiler’s file list and that npm run typecheck:js passes. As a separate check, I introduced a misspelled jQuery or DOM method in each file locally. TypeScript reported each one. Approved for 7.3.
AI review · gpt-6
|
PR #16117 landed in https://core.trac.wordpress.org/changeset/65731 |
Add `xfn.js`, `language-chooser.js`, and `sanitize.js` to the TypeScript compiler inputs. Developed in: #16117 Props faisalahammad. See #66751. git-svn-id: https://develop.svn.wordpress.org/trunk@65731 602fd350-edb4-49c9-b593-d223f7449a82
Add `xfn.js`, `language-chooser.js`, and `sanitize.js` to the TypeScript compiler inputs. Developed in: WordPress/wordpress-develop#16117 Props faisalahammad. See #66751. Built from https://develop.svn.wordpress.org/trunk@65731 git-svn-id: http://core.svn.wordpress.org/trunk@64761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Adds three files to TypeScript checking in
tsconfig.json:src/js/_enqueues/admin/xfn.jssrc/js/_enqueues/lib/language-chooser.jssrc/js/_enqueues/wp/sanitize.jsAll three already pass the existing strict configuration, so this only changes
tsconfig.json. Thefileslist stays sorted.Trac ticket: https://core.trac.wordpress.org/ticket/66751
Testing Instructions
npm run typecheck:jsand confirm there are no errors.npx tsc -p tsconfig.json --listFilesOnly | grep -E 'xfn|language-chooser|sanitize'and confirm all three files are listed.Use of AI Tools
AI assistance: Yes
Tool(s): Claude desktop app (Claude Code)
Model(s): Claude Opus 5.5
Used for: Measuring TypeScript errors per file to find files that already pass, updating
tsconfig.json, running the checks, and writing this description.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.