Skip to content

Media: use updated file path for attachment metadata - #12811

Draft
ArkaPrabhaChowdhury wants to merge 1 commit into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-35593-media-metadata
Draft

Media: use updated file path for attachment metadata#12811
ArkaPrabhaChowdhury wants to merge 1 commit into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-35593-media-metadata

Conversation

@ArkaPrabhaChowdhury

@ArkaPrabhaChowdhury ArkaPrabhaChowdhury commented Aug 3, 2026

Copy link
Copy Markdown

Description

When an add_attachment callback changes an attachment's file, media metadata generation currently uses the stale pre-insert path. Use get_attached_file() after insertion so uploads and sideloads generate metadata for the current file.

Includes regression tests for both paths.

Trac: https://core.trac.wordpress.org/ticket/35593

Testing

  • PHP lint
  • PHPCBF
  • PHPCS
  • PHPUnit could not run because wp-tests-config.php is missing and Docker is unavailable.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant