Prevent empty notifications when prepare fails.#11583
Open
desrosj wants to merge 1 commit intoWordPress:trunkfrom
Open
Prevent empty notifications when prepare fails.#11583desrosj wants to merge 1 commit intoWordPress:trunkfrom
prepare fails.#11583desrosj wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Because of the `failure()` check, the `failure` job runs even when the message's payload is not properly prepared. This adds an additional check to guard against scenarios where the `payload` output is empty.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the
failure()check, thefailurejob runs even when the message's payload is not properly prepared.This adds an additional check to guard against scenarios where the
payloadoutput is empty.This was discovered in this workflow run. The raw logs are being attached so that they persist after the 90 day retention period for logs passes.
Trac ticket: Core-64893.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude
Model(s): Opus 4.6
Used for: Investigating and creating the initial PR.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.