HTML API: Normalize TITLE content generation.#11581
Draft
dmsnell wants to merge 2 commits intoWordPress:trunkfrom
Draft
HTML API: Normalize TITLE content generation.#11581dmsnell wants to merge 2 commits intoWordPress:trunkfrom
dmsnell wants to merge 2 commits intoWordPress:trunkfrom
Conversation
The HTML TITLE element behaves differently than other elements because it contains no content other than parsed character data; in other words, everything until the closing TITLE tag is treated as plaintext, while character references are decoded. WordPress post titles, however, are nominally rich text and may contain markup which will be rendered when displayed inside a theme; just not when found insdie the TITLE element itself. This patch introduces a new semantically-named function to transform rich HTML for rendering into the TITLE element and replaces existing uses of `esc_html()` and `_e()` to parse the input HTML, remove anything that isn’t text, and then normalize the escaping of syntax characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTML TITLE element behaves differently than other elements because it contains no content other than parsed character data; in other words, everything until the closing TITLE tag is treated as plaintext, while character references are decoded.
WordPress post titles, however, are nominally rich text and may contain markup which will be rendered when displayed inside a theme; just not when found insdie the TITLE element itself.
This patch introduces a new semantically-named function to transform rich HTML for rendering into the TITLE element and replaces existing uses of
esc_html()and_e()to parse the input HTML, remove anything that isn’t text, and then normalize the escaping of syntax characters.