Query: Set is_singular in the get_posts()front page backstop#11571
Query: Set is_singular in the get_posts()front page backstop#11571dsas wants to merge 1 commit intoWordPress:trunkfrom
is_singular in the get_posts()front page backstop#11571Conversation
The static front page backstop in `WP_Query::get_posts()` sets `is_page = true` and `is_home = false`, but did not update `is_singular`. This caused the query to generate incorrect SQL — using `post_type = 'post'` instead of `post_type = 'page'` — and return zero results. The equivalent check in `parse_query()` correctly maintains the invariant by recalculating `is_singular` at line 1135. The `get_posts()` backstop now does the same. The backstop fires when `parse_query()` fails to detect the static front page because `$this->query` contains unexpected public query vars (anything not in the allowlist of `preview`, `page`, `paged`, `cpage`). This can happen when a plugin registers a query var that collides with a parameter WordPress core uses in preview URLs. Trac ticket: https://core.trac.wordpress.org/ticket/65072
acb4554 to
2e10f66
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The static front page backstop in
WP_Query::get_posts()setsis_page = trueandis_home = false, but did not updateis_singular. This caused the query to generate incorrect SQL — usingpost_type = 'post'instead ofpost_type = 'page'— and return zero results.The equivalent check in
parse_query()correctly maintains the invariant by recalculatingis_singularat line 1135. Theget_posts()backstop now does the same.The backstop fires when
parse_query()fails to detect the static front page because$this->querycontains unexpected public query vars (anything not in the allowlist ofpreview,page,paged,cpage). This can happen when a plugin registers a query var that collides with a parameter WordPress core uses in preview URLs.Trac ticket: https://core.trac.wordpress.org/ticket/65072
Use of AI Tools
AI assistance: Yes
Tool(s): Claude
Model(s): Claude Opus 4.6
Used for: Investigation, implementation, review and test; final implementation and tests were also reviewed and tested by myself
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.