Skip to content

Query: Set is_singular in the get_posts()front page backstop#11571

Open
dsas wants to merge 1 commit intoWordPress:trunkfrom
dsas:fix/65072-query-var-read-page
Open

Query: Set is_singular in the get_posts()front page backstop#11571
dsas wants to merge 1 commit intoWordPress:trunkfrom
dsas:fix/65072-query-var-read-page

Conversation

@dsas
Copy link
Copy Markdown

@dsas dsas commented Apr 14, 2026

The static front page backstop in WP_Query::get_posts() sets is_page = true and is_home = false, but did not update is_singular. This caused the query to generate incorrect SQL — using post_type = 'post' instead of post_type = 'page' — and return zero results.

The equivalent check in parse_query() correctly maintains the invariant by recalculating is_singular at line 1135. The get_posts() backstop now does the same.

The backstop fires when parse_query() fails to detect the static front page because $this->query contains unexpected public query vars (anything not in the allowlist of preview, page, paged, cpage). This can happen when a plugin registers a query var that collides with a parameter WordPress core uses in preview URLs.

Trac ticket: https://core.trac.wordpress.org/ticket/65072

Use of AI Tools

AI assistance: Yes
Tool(s): Claude
Model(s): Claude Opus 4.6
Used for: Investigation, implementation, review and test; final implementation and tests were also reviewed and tested by myself


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

The static front page backstop in `WP_Query::get_posts()` sets `is_page = true` and `is_home = false`, but did not update `is_singular`. This caused the query to generate incorrect SQL — using `post_type = 'post'` instead of `post_type = 'page'` — and return zero results.

The equivalent check in `parse_query()` correctly maintains the invariant by recalculating `is_singular` at line 1135. The `get_posts()` backstop now does the same.

The backstop fires when `parse_query()` fails to detect the static front page because `$this->query` contains unexpected public query vars (anything not in the allowlist of `preview`, `page`, `paged`, `cpage`). This can happen when a plugin registers a query var that collides with a parameter WordPress core uses in preview URLs.

Trac ticket: https://core.trac.wordpress.org/ticket/65072
@dsas dsas force-pushed the fix/65072-query-var-read-page branch from acb4554 to 2e10f66 Compare April 14, 2026 12:53
@dsas dsas marked this pull request as ready for review April 14, 2026 12:54
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dsas.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant