Skip to content

Conversation

@westonruter
Copy link
Member

See https://core.trac.wordpress.org/ticket/61734#comment:55

This reverts the WP_Script_Modules::get_dependencies() change in 25420f0 which was developed in #9867 to fix Core-63486.

As of WP 6.8, WP_Script_Modules::get_dependencies() had this return signature:

* @return array[] List of dependencies, keyed by script module identifier.

The aforementioned commit for 6.9 changed it to:

* @return string[] List of IDs for script module dependencies.

Since the method was private, I didn't think there would be a problem to make this change. However, it turns out that Query Monitor is using this private method via the Reflection API. This is because core is not yet exposing the necessary accessor methods from WP_Script_Modules, and so QM is forced to use a private method. This is something which should be no longer be necessary as of Core-60597.

In the meantime, we can restore the original return value for the method since it isn't particularly difficult to do so for 6.9-beta2.

Trac ticket: https://core.trac.wordpress.org/ticket/61734


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props westonruter, pbiron.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@pbiron
Copy link

pbiron commented Oct 26, 2025

An initial test of this PR applied to 6.9-beta1 seems to resolve the problem I reported in https://core.trac.wordpress.org/ticket/61734#comment:52. I'll test some more tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants