Restore original return value for WP_Script_Modules::get_dependencies()
#10403
+20
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://core.trac.wordpress.org/ticket/61734#comment:55
This reverts the
WP_Script_Modules::get_dependencies()change in 25420f0 which was developed in #9867 to fix Core-63486.As of WP 6.8,
WP_Script_Modules::get_dependencies()had this return signature:wordpress-develop/src/wp-includes/class-wp-script-modules.php
Line 306 in 58edb2f
The aforementioned commit for 6.9 changed it to:
wordpress-develop/src/wp-includes/class-wp-script-modules.php
Line 569 in 7a840d3
Since the method was private, I didn't think there would be a problem to make this change. However, it turns out that Query Monitor is using this private method via the Reflection API. This is because core is not yet exposing the necessary accessor methods from
WP_Script_Modules, and so QM is forced to use a private method. This is something which should be no longer be necessary as of Core-60597.In the meantime, we can restore the original return value for the method since it isn't particularly difficult to do so for 6.9-beta2.
Trac ticket: https://core.trac.wordpress.org/ticket/61734
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.