Add an exclusion to prevent building full-page of interactivity-router #10396
Conversation
The full-page wpScriptModuleExport defined in interactivity-router should not be bundled in Wordpress core yet as it is experimental. There is no mechanism in wpScriptModuleExports right now that supports building a script module but not including it in core. Since this is likely to be a rare instance we have opted to hard-code an exclusion in core's build until this module is no longer experimental.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @1178653+wordpress-develop-pr-bot[bot]@users.noreply.github.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| // Exclude the experimental './full-page' export from @wordpress/interactivity-router. | ||
| // This export is defined in Gutenberg's package.json but should not be bundled in Core | ||
| // as the feature is still experimental and not ready for inclusion. | ||
| if ( moduleName === 'interactivity-router' && exportName === './full-page' ) { |
There was a problem hiding this comment.
Newbe question, why is this module defined in "interactivity-router" and not its own package that I guess depends on @wordpress/interactivity-router
There was a problem hiding this comment.
I'll cc @luisherranz and @DAreRodz on that question, because I don't have context for the decision.
There was a problem hiding this comment.
I'll let @DAreRodz confirm it, but I think it's one of the cases that was considered and in principle it would be possible.
In any case, that wouldn't prevent us from the need to add a hardcoded exclusion in WordPress Core, would it?
There was a problem hiding this comment.
Yeah, it should be possible. It's bundled as a separate module, and its only dependency is @wordpress/interactivity-router. I don't remember why we decided to keep both modules in the same package, to be honest. 😄
@youknowriad, just curious. Is it expected that Gutenberg packages only expose one module?
There was a problem hiding this comment.
@youknowriad, just curious. Is it expected that Gutenberg packages only expose one module?
Well for a long time, the expectation was 1 package = 1 script, and then when we did modules, we went on a different direction (started on interactivity).
I don't mind much, but I think we need clarity:
- Should we allow multiple "scripts" like we allow "scripts modules"
- How do we decide if we should do a separate package or not?
5 participants
The full-page wpScriptModuleExport defined in interactivity-router should not be bundled in Wordpress core yet as it is experimental. There is no mechanism in wpScriptModuleExports right now that supports building a script module but not including it in core. Since this is likely to be a rare instance we have opted to hard-code an exclusion in core's build until this module is no longer experimental.
Trac ticket: https://core.trac.wordpress.org/ticket/64137
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.