-
Notifications
You must be signed in to change notification settings - Fork 49
Add milestone automation for merged PRs #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #356 +/- ##
============================================
- Coverage 53.67% 51.01% -2.66%
Complexity 4410 4410
============================================
Files 298 298
Lines 39424 39424
============================================
- Hits 21161 20113 -1048
- Misses 18263 19311 +1048
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm not entirely sure about the closed milestone behavior. I'm not sure I like the idea that an aspect of a PR that I set manually -- the milestone -- might be automatically changed when I merge it. I guess it's meant to help me in case I forget to assign a new milestone if the previous one was already closed, but to me, it seems like it actually removes confidence, because now it feels like I'll always have to double-check. Maybe I'm biased by my experience with Gutenberg, where the milestone is closed when the RC is published, meaning that any bugfixes that need to go in afterwards and before the stable version is released will need to be assigned a closed milestone. I guess the release workflow is different for SCF (?) Anyway, how about we don't update the milestone if it's closed and instead add a comment to notify the PR author to make sure they're aware? |
|
I'm fine backing off the closed milestone process. It may be a solution in search of a problem. |
Fixes #152
Summary
Adds a GitHub workflow that automatically manages milestones for merged PRs. Inspired by Gutenberg's project-management-automation, but simplified for our release process.
Behavior
Milestone Selection Priority
6.8.1before6.9.0)Key Differences from Gutenberg
pushto trunkpull_request_targetclosedpackage.jsonComment on Closed Milestone
When a PR is merged with a closed milestone, it's automatically moved and a comment is added:
Test plan