Run npm verbosely when debug mode is enabled - #340
Open
ekamran wants to merge 1 commit into
Open
Conversation
When an npm command hangs or misbehaves during preparation, the runner shows nothing that explains where it is stuck. Append --loglevel=silly to the npm install and build commands when WPT_DEBUG is set, matching how debug mode already adds verbosity to the rsync operations. Default behavior is unchanged. Based on the approach in WordPress#221 by @rollecode, updated to gate the verbosity behind WPT_DEBUG as suggested in the review discussion.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an npm command hangs or misbehaves during preparation, the runner shows nothing about where it is stuck. The original hang report (#222) was resolved by a Node version bump in #225, but that fixed only that incident. A future npm hang still produces no output to diagnose.
This adds npm verbosity behind the existing debug mode, as suggested in the #221 discussion: when WPT_DEBUG is set, the npm install and npm run build commands in prepare.php run with --loglevel=silly, which is npm's maximum logging level and the long form of the -ddd flag from #221. Default behavior is unchanged. The gate mirrors how debug mode already adds verbosity to the rsync operations in the same file.
README.md and .env.default are updated in the places that document WPT_DEBUG, so the sample env file and the docs match the behavior.
This supersedes #221 by @rollecode, whose PR established the idea. It was based on an older prepare.php from before the runner_vars refactor, so this is a fresh commit on current master with the WPT_DEBUG gate the reviewers asked for.
Verification:
Use of AI
AI assistance: Yes
Tool(s): Claude Code and Codex
Used for: Investigation, implementation review, edge-case testing, and PR wording. I reviewed the reasoning and test results, and I take responsibility for the contribution.