Ports WordPress#339 (fixes upstream WordPress#311) into the fork, adapted to our terminus-fetched $logs_local paths. c65ae74 guarded *around* process_junit_xml() — a filesize() check before and an empty-return check after. The second guard was unreachable: on unparseable XML, simplexml_load_string() returns false and the function fatals at $xml->xpath() before it can return, which is exactly the uncaught Error every host hit in April (upstream WordPress#310, raw 0x80 bytes in the email test data). Verified against main: the poisoned fixture dies with "Call to a member function xpath() on bool", not our message. Guards now live in process_junit_xml() where the parse happens: - empty input aborts with a clear message - parse failure aborts and reports the first libxml error and line number, restoring the previous libxml handler state either way - missing tests/failures/errors counts abort, because a payload with a test count but no failure/error counts casts to zero downstream and renders as Passed — the actual WordPress#311 false positive - a root-level <testsuite> now parses (xpath drops the //testsuites// prefix); no-op for PHPUnit output, whose root is always <testsuites> report.php keeps the crash/OOM-specific message for the 0-byte case (our libaom SIGABRT signature, see BUGS-11823), adds is_readable(), and drops the now-dead post-call guard. Verified with a local fixture battery (no unit suite in this repo): valid PHPUnit XML produces byte-identical output to main; empty, 0x80-poisoned, no-testsuite, and missing-counts fixtures each exit 1 with a distinct message; tests="0" and root-<testsuite> pass through. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Uh oh!

test results default to success at 0 bytes #311

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions