Skip to content

Fix checking if plugin status is not install #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Fix checking if plugin status is not install #1127

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e350350
Fix checking if plugin status is not install
westonruter Apr 12, 2024
4dc6ed2
Merge branch 'release/3.0.0' into fix/plugin-install-status
mukeshpanchal27 Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions includes/admin/plugins.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ function perflab_render_plugin_card( array $plugin_data ) {
current_user_can( 'activate_plugins' )
) &&
(
'install' !== $status ||
'install' !== $status['status'] ||
current_user_can( 'install_plugins' )
)
) {
Expand All @@ -186,7 +186,7 @@ function perflab_render_plugin_card( array $plugin_data ) {
esc_html__( 'Activate', 'default' )
);
} else {
$explanation = 'install' !== $status || current_user_can( 'install_plugins' ) ? _x( 'Cannot Activate', 'plugin', 'default' ) : _x( 'Cannot Install', 'plugin', 'default' );
$explanation = 'install' !== $status['status'] || current_user_can( 'install_plugins' ) ? _x( 'Cannot Activate', 'plugin', 'default' ) : _x( 'Cannot Install', 'plugin', 'default' );
$action_links[] = sprintf(
'<button type="button" class="button button-disabled" disabled="disabled">%s</button>',
esc_html( $explanation )
Expand Down