Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add do_blocks to the $autoEscapedFunctions list #2525

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dossy
Copy link

@dossy dossy commented Mar 24, 2025

Add do_blocks to the $autoEscapedFunctions list.

Closes #2524.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The do_blocks() function doesn't produce output, but returns instead, so it doesn't belong in the $autoEscapedFunctions list.

I also don't see the function escaping the output, so as far as I can see, it should also not be considered an escaping function. It's a re-rendering function, not an escaping function.

@dossy
Copy link
Author

dossy commented Apr 5, 2025

The do_blocks() function doesn't produce output, but returns instead, so it doesn't belong in the $autoEscapedFunctions list.

I also don't see the function escaping the output, so as far as I can see, it should also not be considered an escaping function. It's a re-rendering function, not an escaping function.

The exact same things can be said about do_shortcode(), and yet it is in the $autoEscapedFunctions list.

do_blocks() should be added for the exact same reasons do_shortcode() was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add do_blocks to the $autoEscapedFunctions list
2 participants