-
-
Notifications
You must be signed in to change notification settings - Fork 509
Docs/WordPress.Arrays.ArrayIndentation #1744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jrfnl
merged 6 commits into
WordPress:develop
from
Mike-Hermans:docs/Arrays.ArrayIndentation
Oct 13, 2019
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8c065c4
Adds docs for WordPress.Arrays.ArrayIndentation
Mike-Hermans 384c045
Simple fixes
Mike-Hermans 5f287ab
Multine array items
Mike-Hermans 026f54d
Updated multiline array explanation
Mike-Hermans 65dd623
Heredoc documentation
Mike-Hermans df478f2
Fixes
Mike-Hermans File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
<documentation title="Array Indentation"> | ||
<standard> | ||
<![CDATA[ | ||
The array closing bracket and indentation should line up with the start of the content on the line containing the array opener. | ||
]]> | ||
</standard> | ||
<code_comparison> | ||
<code title="Valid: Closing bracket lined up correctly"> | ||
<![CDATA[ | ||
$args = array( | ||
'post_id' => 22, | ||
<em>);</em> | ||
]]> | ||
</code> | ||
<code title="Invalid: Closing bracket lined up incorrectly"> | ||
<![CDATA[ | ||
$args = array( | ||
'post_id' => 22, | ||
Mike-Hermans marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<em>);</em> | ||
]]> | ||
</code> | ||
</code_comparison> | ||
<standard> | ||
<![CDATA[ | ||
Keys in each array and nested array should be indented by a 4-space tab for each level of nested array, so that the array visually matches its structure. | ||
jrfnl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
]]> | ||
</standard> | ||
<code_comparison> | ||
<code title="Valid: Correctly indented array"> | ||
<![CDATA[ | ||
$args = array( | ||
'post_id' => 22, | ||
'comment_count' => array( | ||
<em>'value' => 25, | ||
'compare' => '>=',</em> | ||
), | ||
); | ||
]]> | ||
</code> | ||
<code title="Invalid: Indented incorrectly; harder to read."> | ||
<![CDATA[ | ||
$args = array( | ||
'post_id' => 22, | ||
'comment_count' => array( | ||
<em>'value' => 25, | ||
'compare' => '>=',</em> | ||
), | ||
); | ||
]]> | ||
</code> | ||
</code_comparison> | ||
</documentation> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.