PHP 8.5 | CaseInsensitiveDictionary: final touches #984
+3
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. PR 956 added some defensive coding to the `offset*()` methods in the `CaseInsensitiveDictionary` class, but was a little overzealous by also adding the defensive coding in the `offsetSet()` method which already would throw an exception and didn't need the extra defensive coding. This has been cleaned up now. 2. When running the tests on PHP 8.5, two more test-only deprecation notices show up, though they don't fail the tests due to the deprecation being hit in a class constant definition, i.e. when reading the class: ``` Deprecated: Using null as an array offset is deprecated, use an empty string instead in path/to/Requests/tests/Utility/CaseInsensitiveDictionary/ArrayAccessTest.php on line 24 Deprecated: Using null as an array offset is deprecated, use an empty string instead in path/to/Requests/tests/Utility/CaseInsensitiveDictionary/GetAllTest.php on line 19 ``` In both cases, the downlow of it is that PHP would _already_ convert the `null` key in the class constant to an empty string _at definition of the array_, so whether the array is declared with a `null` key or a `''` (empty string) key doesn't make any actual difference for the tests as by the time the data would hit the test code, the key would already be converted to an empty string. With that in mind, I've taken the decision to make this empty string key explicit. This doesn't diminish the value of the test and the guard code for the `offset*()` methods receiving a `null` `$key` is still being tested via the `ArrayAccessTest::testOffsetSetWithoutKey()` test and the `ArrayAccessTest::testAccessValidEntries()` with the "Null key will be converted to empty string" data set which is still in place as the data for that test is created via the `DATASET_REVERSED` constant (instead of the `DATASET` constant). This was previously designed this way explicitly to allow for testing the `null` offset case.
schlessera
requested changes
Nov 21, 2025
schlessera
approved these changes
Nov 21, 2025
schlessera
deleted the
feature/php-8.5-fix-caseinsensitive-dictionary-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Detailed Description
PR PHP 8.5 | Fix various "Using null as an array offset" deprecation notices #956 added some defensive coding to the
offset*()methods in theCaseInsensitiveDictionaryclass, but was a little overzealous by also adding the defensive coding in theoffsetSet()method which already would throw an exception and didn't need the extra defensive coding. This has been cleaned up now.When running the tests on PHP 8.5, two more test-only deprecation notices show up, though they don't fail the tests due to the deprecation being hit in a class constant definition, i.e. when reading the class:
In both cases, the downlow of it is that PHP would already convert the
nullkey in the class constant to an empty string at definition of the array, so whether the array is declared with anullkey or a''(empty string) key doesn't make any actual difference for the tests as by the time the data would hit the test code, the key would already be converted to an empty string.With that in mind, I've taken the decision to make this empty string key explicit.
This doesn't diminish the value of the test and the guard code for the
offset*()methods receiving anull$keyis still being tested via theArrayAccessTest::testOffsetSetWithoutKey()test and theArrayAccessTest::testAccessValidEntries()with the "Null key will be converted to empty string" data set which is still in place as the data for that test is created via theDATASET_REVERSEDconstant (instead of theDATASETconstant). This was previously designed this way explicitly to allow for testing thenulloffset case.