Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed several issues with the LLM being unable to properly reference audio/video expressions #949

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fixed several issues with the LLM being unable to properly reference audio/video expressions #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Source/Chatbook/Prompting.wl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ $basePromptOrder = {
"ConversionGraphics",
"MarkdownImageBox",
"MarkdownImageBoxImporting",
"AudioBoxImporting",
"VideoBoxImporting",
"Checkboxes",
"CheckboxesIndeterminate",
"ConversionFormatting",
Expand Down Expand Up @@ -83,6 +85,8 @@ $basePromptDependencies = Append[ "GeneralInstructionsHeader" ] /@ <|
"ConversionGraphics" -> { "MessageConversionHeader" },
"MarkdownImageBox" -> { "MessageConversionHeader" },
"MarkdownImageBoxImporting" -> { "MarkdownImageBox" },
"AudioBoxImporting" -> { "MarkdownImageBoxImporting" },
"VideoBoxImporting" -> { "MarkdownImageBoxImporting" },
"ConversionFormatting" -> { "MessageConversionHeader" },
"ExternalLanguageCells" -> { "MessageConversionHeader" },
"SpecialURI" -> { },
Expand Down Expand Up @@ -202,6 +206,12 @@ $basePromptComponents[ "MarkdownImageBoxImporting" ] = "\
tool. For example, ``ColorNegate[<!attachment://content-id!>]``. The expression will be inserted in place. Do not \
include the MarkdownImageBox wrapper. You can also use this syntax to inline images into WL code blocks.";

$basePromptComponents[ "AudioBoxImporting" ] = "\
* You can also use this syntax for audio that similarly appears in AudioBox[...].";

$basePromptComponents[ "VideoBoxImporting" ] = "\
* You can also use this syntax for video that similarly appears in VideoBox[...].";

$basePromptComponents[ "Checkboxes" ] = "\
* Checkboxes in the UI will be replaced with one of the following text representations:
* A Checkbox that's selected becomes ``[\[Checkmark]]``
Expand Down
13 changes: 12 additions & 1 deletion Source/Chatbook/Sandbox.wl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2070,7 +2070,7 @@ inlineExpressionURI[ uri_String ] :=
inlineExpressionURI[ uri_, failed_? FailureQ ] :=
makeCachedBoxes @ failed;

inlineExpressionURI[ uri_, HoldComplete[ expr_ ] ] /; graphicsQ @ Unevaluated @ expr :=
inlineExpressionURI[ uri_, HoldComplete[ expr_? makeCachedBoxesQ ] ] :=
makeCachedBoxes @ expr;

inlineExpressionURI[ uri_, HoldComplete[ expr_ ] ] :=
Expand All @@ -2083,6 +2083,17 @@ inlineExpressionURI[ uri_, HoldComplete[ expr_ ] ] :=

inlineExpressionURI // endDefinition;

(* ::**************************************************************************************************************:: *)
(* ::Subsubsection::Closed:: *)
(*makeCachedBoxesQ*)
makeCachedBoxesQ // beginDefinition;
makeCachedBoxesQ // Attributes = { HoldAllComplete };
makeCachedBoxesQ[ audio_Audio ] := AudioQ @ Unevaluated @ audio;
makeCachedBoxesQ[ video_Video ] := VideoQ @ Unevaluated @ video;
makeCachedBoxesQ[ graph_Graph ] := GraphQ @ Unevaluated @ graph;
makeCachedBoxesQ[ expr_ ] := graphicsQ @ Unevaluated @ expr;
makeCachedBoxesQ // endDefinition;

(* ::**************************************************************************************************************:: *)
(* ::Subsubsection::Closed:: *)
(*makeCachedBoxes*)
Expand Down
11 changes: 7 additions & 4 deletions Source/Chatbook/SendChat.wl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,14 +894,17 @@ autoCorrect // beginDefinition;
autoCorrect[ string_String ] := StringReplace[ string, $llmAutoCorrectRules ];
autoCorrect // endDefinition;


$$specialBoxName = "AudioBox"|"MarkdownImageBox"|"VideoBox";

$llmAutoCorrectRules := $llmAutoCorrectRules = Flatten @ {
StartOfLine ~~ WhitespaceCharacter... ~~ "/command\ncode:" :> "/wl\ncode:",
"```" ~~ code: Except[ "\n" ].. ~~ "```" :> "``"<>code<>"``",
"wolfram_language_evaliator" -> "wolfram_language_evaluator",
"\\!\\(\\*MarkdownImageBox[\"" ~~ Shortest[ uri__ ] ~~ "\"]\\)" :> uri,
"\\!\\(MarkdownImageBox[\"" ~~ Shortest[ uri__ ] ~~ "\"]\\)" :> uri,
"\"\\\\!\\\\(\\\\*MarkdownImageBox[\\\"" ~~ Shortest[ uri__ ] ~~ "\\\"]\\\\)\"" :> uri,
"\"\\\\!\\\\(MarkdownImageBox[\\\"" ~~ Shortest[ uri__ ] ~~ "\\\"]\\\\)\"" :> uri,
"\\!\\(\\*"~~$$specialBoxName~~"[\"" ~~ Shortest[ uri__ ] ~~ "\"]\\)" :> uri,
"\\!\\("~~$$specialBoxName~~"[\"" ~~ Shortest[ uri__ ] ~~ "\"]\\)" :> uri,
"\"\\\\!\\\\(\\\\*"~~$$specialBoxName~~"[\\\"" ~~ Shortest[ uri__ ] ~~ "\\\"]\\\\)\"" :> uri,
"\"\\\\!\\\\("~~$$specialBoxName~~"[\\\"" ~~ Shortest[ uri__ ] ~~ "\\\"]\\\\)\"" :> uri,
"<" ~~ Shortest[ scheme: LetterCharacter.. ~~ "://" ~~ id: Except[ "!" ].. ] ~~ ">" :>
"<!" <> scheme <> "://" <> id <> "!>",
"\\uf351" -> "\[FreeformPrompt]",
Expand Down
9 changes: 6 additions & 3 deletions Source/Chatbook/Serialization.wl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,6 +1202,7 @@ serializeVideo[ box: TemplateBox[ _, "VideoBox1"|"VideoBox2", ___ ] ] := seriali

serializeVideo[ box_, video_ ] := Enclose[
If[ VideoQ @ video,
If[ toolSelectedQ[ "WolframLanguageEvaluator" ], needsBasePrompt[ "VideoBoxImporting" ] ];
"\\!\\(\\*VideoBox[\"" <> ConfirmBy[ MakeExpressionURI @ video, StringQ, "URI" ] <> "\"]\\)",
"\\!\\(\\*VideoBox[...]\\)"
],
Expand All @@ -1214,17 +1215,19 @@ serializeVideo // endDefinition;
(* ::Subsubsubsection::Closed:: *)
(*Audio*)
fasterCellToString0[ box: TagBox[ _, _Audio`AudioBox, ___ ] ] := serializeAudio @ box;
fasterCellToString0[ box: TemplateBox[ _, "AudioBox1", ___ ] ] := serializeAudio @ box;

(* ::**************************************************************************************************************:: *)
(* ::Subsubsubsubsection::Closed:: *)
(*serializeAudio*)
serializeAudio // beginDefinition;

serializeAudio[ box: TagBox[ content_, _Audio`AudioBox, ___ ] ] := serializeAudio[ box ] =
serializeAudio[ content, Quiet @ ToExpression[ box, StandardForm ] ];
serializeAudio[ box_ ] := serializeAudio[ box ] =
serializeAudio[ box, Quiet @ ToExpression[ box, StandardForm ] ];

serializeAudio[ content_, audio_ ] := Enclose[
serializeAudio[ box_, audio_ ] := Enclose[
If[ AudioQ @ audio,
If[ toolSelectedQ[ "WolframLanguageEvaluator" ], needsBasePrompt[ "AudioBoxImporting" ] ];
"\\!\\(\\*AudioBox[\"" <> ConfirmBy[ MakeExpressionURI @ audio, StringQ, "URI" ] <> "\"]\\)",
"\\!\\(\\*AudioBox[...]\\)"
],
Expand Down
Loading