Skip to content

change android's getSocket access modifier to public #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crystalstorm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change android's getSocket access modifier to public #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions android/src/main/java/com/itsclicking/clickapp/fluttersocketio/ISocketIOManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,7 @@ public interface ISocketIOManager {
void disconnect(String domain, String namespace);
void destroySocket(String domain, String namespace);
void destroyAllSockets();

String getSocketId(String domain, String namespace);
SocketIO getSocket(String socketId);
}
4 changes: 2 additions & 2 deletions android/src/main/java/com/itsclicking/clickapp/fluttersocketio/SocketIOManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ private SocketIOManager() {
mSockets = new HashMap<>();
}

private SocketIO getSocket(String socketId) {
public SocketIO getSocket(String socketId) {
if(mSockets != null && !Utils.isNullOrEmpty(socketId)) {
Utils.log("TOTAL SOCKETS: ", String.valueOf(mSockets.size()));
return mSockets.get(socketId);
Expand Down Expand Up @@ -58,7 +58,7 @@ private boolean isConnected(SocketIO socketIO) {
return socketIO != null && socketIO.isConnected();
}

private String getSocketId(String domain, String namespace) {
public String getSocketId(String domain, String namespace) {
if(!Utils.isNullOrEmpty(domain)) {
return domain + (namespace != null ? namespace : "");
}
Expand Down