Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload HookContainer service when MediawikiServices is reloaded #116

Open
wants to merge 1 commit into
base: REL1_43-Fandom
Choose a base branch
from
Open

Reload HookContainer service when MediawikiServices is reloaded #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions includes/MediaWikiServices.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,12 @@ public static function resetGlobalInstance( ?Config $bootstrapConfig = null, $qu
self::failIfResetNotAllowed( __METHOD__ );

$oldInstance = self::$instance;
/* fandom change start */
// MW 1.43 uses StaticHookRegistry which is supposed to be initialized once and after all
// extensions are loaded, while at Fandom we initialize it early and some of the hooks
// (eg. MediawikiServices) do not trigger all the handlers in the end
$oldInstance->resetService( 'HookContainer' );
/* fandom change end */
self::$instance = self::newInstance(
$bootstrapConfig ?? self::$instance->getBootstrapConfig(),
'load'
Expand Down