Skip to content

Lock Receipt during validation and other concurrency improvements #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Lock Receipt during validation and other concurrency improvements #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 39 additions & 30 deletions django_afip/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
from django.core.validators import MinValueValidator
from django.db import connection
from django.db import models
from django.db import transaction
from django.db.models import CheckConstraint
from django.db.models import Count
from django.db.models import F
Expand Down Expand Up @@ -944,41 +945,44 @@ def validate(self, ticket: AuthTicket | None = None) -> list[str]:
return []

qs.order_by("issued_date", "id")._assign_numbers()
ids = qs.values_list("id", flat=True)

ticket = ticket or first.point_of_sales.owner.get_or_create_ticket("wsfe")
client = clients.get_client("wsfe", first.point_of_sales.owner.is_sandboxed)
response = client.service.FECAESolicitar(
serializers.serialize_ticket(ticket),
serializers.serialize_multiple_receipts(qs),
)
check_response(response)
errs = []
for cae_data in response.FeDetResp.FECAEDetResponse:
if cae_data.Resultado == ReceiptValidation.RESULT_APPROVED:
validation = ReceiptValidation.objects.create(
result=cae_data.Resultado,
cae=cae_data.CAE,
cae_expiration=parsers.parse_date(cae_data.CAEFchVto),
receipt=qs.get(
receipt_number=cae_data.CbteDesde,
),
processed_date=parsers.parse_datetime(
response.FeCabResp.FchProceso,
),
)
if cae_data.Observaciones:
with transaction.atomic():
qs = Receipt.objects.filter(id__in=ids, receipt_number__isnull=False).select_for_update()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podés reusar el QuerySet existente acá:

Suggested change
qs = Receipt.objects.filter(id__in=ids, receipt_number__isnull=False).select_for_update()
qs = qs.select_for_update()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eso intenté en un principio, pero me da esta excepción:

self = <django.db.backends.utils.CursorWrapper object at 0x7f219c6762a0>
sql = 'SELECT "afip_receipt"."id", "afip_receipt"."point_of_sales_id", "afip_receipt"."receipt_type_id", "afip_receipt"."con..."."id" = %s AND "afip_receiptvalidation"."id" IS NULL) ORDER BY "afip_receipt"."receipt_number" ASC LIMIT 1 FOR UPDATE'
params = (12,), ignored_wrapper_args = (False, {'connection': <DatabaseWrapper vendor='postgresql' alias='default'>, 'cursor': <django.db.backends.utils.CursorWrapper object at 0x7f219c6762a0>})

    def _execute(self, sql, params, *ignored_wrapper_args):
        # Raise a warning during app initialization (stored_app_configs is only
        # ever set during testing).
        if not apps.ready and not apps.stored_app_configs:
            warnings.warn(self.APPS_NOT_READY_WARNING_MSG, category=RuntimeWarning)
        self.db.validate_no_broken_transaction()
        with self.db.wrap_database_errors:
            if params is None:
                # params default might be backend specific.
                return self.cursor.execute(sql)
            else:
>               return self.cursor.execute(sql, params)
E               django.db.utils.NotSupportedError: FOR UPDATE cannot be applied to the nullable side of an outer join

.tox/live/lib/python3.12/site-packages/django/db/backends/utils.py:105: NotSupportedError

Me parece que el problema es el qs = self.filter(validation__isnull=True) de un par de lineas más arriba. Por lo que leí, Postgres dice que no puede lockear las filas según un criterio como ese, porque en cualquier momento podría suceder que validation__isnull=True si se agregara un Validation que apunte al Receipt; tendría que lockear la tabla Validations entera supongo, o algo similar.

Decime si estoy tirando fruta, no sé mucho PG pero menos aun Django

ticket = ticket or first.point_of_sales.owner.get_or_create_ticket("wsfe")
client = clients.get_client("wsfe", first.point_of_sales.owner.is_sandboxed)
response = client.service.FECAESolicitar(
serializers.serialize_ticket(ticket),
serializers.serialize_multiple_receipts(qs),
)
check_response(response)
for cae_data in response.FeDetResp.FECAEDetResponse:
if cae_data.Resultado == ReceiptValidation.RESULT_APPROVED:
validation = ReceiptValidation.objects.create(
result=cae_data.Resultado,
cae=cae_data.CAE,
cae_expiration=parsers.parse_date(cae_data.CAEFchVto),
receipt=qs.get(
receipt_number=cae_data.CbteDesde,
),
processed_date=parsers.parse_datetime(
response.FeCabResp.FchProceso,
),
)
if cae_data.Observaciones:
for obs in cae_data.Observaciones.Obs:
observation = Observation.objects.create(
code=obs.Code,
message=obs.Msg,
)
validation.observations.add(observation)
elif cae_data.Observaciones:
for obs in cae_data.Observaciones.Obs:
observation = Observation.objects.create(
code=obs.Code,
message=obs.Msg,
)
validation.observations.add(observation)
elif cae_data.Observaciones:
for obs in cae_data.Observaciones.Obs:
errs.append(f"Error {obs.Code}: {parsers.parse_string(obs.Msg)}")
errs.append(f"Error {obs.Code}: {parsers.parse_string(obs.Msg)}")

# Remove the number from ones that failed to validate:
qs.filter(validation__isnull=True).update(receipt_number=None)
Receipt.objects.filter(id__in=ids, validation__isnull=True).update(receipt_number=None)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem


return errs

Expand Down Expand Up @@ -1334,6 +1338,11 @@ def revalidate(self) -> ReceiptValidation | None:
)
validation.observations.add(observation)
return validation

# Update atomically, skip if it was just validated
Receipt.objects.filter(pk=self.pk, validation__isnull=True).update(
receipt_number=None,
)
return None

def approximate_date(receipt: Receipt) -> bool:
Expand Down