Skip to content

fix: SVG elements keep the case of their tagName in an HTML document #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonasporto wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: SVG elements keep the case of their tagName in an HTML document #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cjs/svg/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ class SVGElement extends Element {
return 'http://www.w3.org/2000/svg';
}

// https://dom.spec.whatwg.org/#element-html-uppercased-qualified-name
// only elements in the HTML namespace are upper-cased in an HTML document
get nodeName() { return this.localName; }
get tagName() { return this.localName; }

getAttribute(name) {
return name === 'class' ?
[...this.classList].join(' ') :
Expand Down
5 changes: 5 additions & 0 deletions esm/svg/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ export class SVGElement extends Element {
return 'http://www.w3.org/2000/svg';
}

// https://dom.spec.whatwg.org/#element-html-uppercased-qualified-name
// only elements in the HTML namespace are upper-cased in an HTML document
get nodeName() { return this.localName; }
get tagName() { return this.localName; }

getAttribute(name) {
return name === 'class' ?
[...this.classList].join(' ') :
Expand Down
8 changes: 8 additions & 0 deletions test/svg/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ document = (new DOMParser).parseFromString(`<!doctype html><html><svg><rect /></

assert('ownerSVGElement' in document.querySelector('svg rect'), true, 'svg restored');

// https://github.com/WebReflection/linkedom/issues/344
assert(document.querySelector('svg').tagName, 'svg', '<svg> tagName keeps its case in an HTML document');
assert(document.querySelector('svg rect').tagName, 'rect', '<rect> tagName keeps its case in an HTML document');
assert(document.querySelector('svg rect').nodeName, 'rect', '<rect> nodeName keeps its case in an HTML document');
assert(document.createElementNS('http://www.w3.org/2000/svg', 'path').tagName, 'path', 'createElementNS tagName keeps its case');
assert(document.createElementNS('http://www.w3.org/2000/svg', 'path').nodeName, 'path', 'createElementNS nodeName keeps its case');
assert(document.documentElement.tagName, 'HTML', 'HTML elements are still upper-cased');

svg.className.what = 'ever';

assert(svg.className.what, 'ever', '<svg>.className');
Expand Down