Use explicit 3.0 version in logo#297
Use explicit 3.0 version in logo#297camillobruni wants to merge 2 commits intoWebKit:JetStream3.0from
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
danleh
left a comment
There was a problem hiding this comment.
LGTM with nit. Lets also update the main branch afterwards (this PR goes to the 3.0 branch directly)
There was a problem hiding this comment.
tiny typography nit: Could you very slightly reduce the letter spacing around the . in 3.0?
|
I don't have super strong feelings about this but one downside is that incremental updates require touching up the logo. I kinda prefer the paragraph at the top so we can quickly roll out the number. |
|
It would be in sync with speedometer where we did the same change (though the "logo" is just text): It would just eliminate an easy source of error if we ever do an incremental dot-release. |
What easy source of error are you thinking? That we copy the wrong branch? I guess I'd prefer to make this change in 3.1 (if needed). |
This makes it easier to spot minor fixes in the future.