Reduce dotnet runtime #168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@maraf Have you seen issues with different builds of the same sources failing? Also, do you have comments or concerns with the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a parameter to pass in the BenchTask batch size from benchmark.js. This makes it possible to change the workload without rebuilding the .wasm blobs. The new batch size is dramatically smaller (100/50/10 for old/aot/interp respectively). I also reduced the frame size for the RayTracing half of the benchmark.
Overall though the distribution of time within the .NET wasm blobs is roughly the same between the two versions (in jsc anyway). With the exception of the interpreter subtest spending roughly 10% longer in the interpreter loop.
Lastly, I added some commentary to the README.md about what the benchmark is doing.
N.B.: I tried to remove the old BenchSize getter but that caused some .NET Out of Memory exceptions in the MONO runtime. The whole build process seems weirdly flakey. Sometimes the build will just not run. In fact 0b7a21d is one that fails and the subsequent commit e3dc40e (which didn't change anything, just rebuilt) works.