Update/rewrite web-tooling-benchmark #153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kmiller68
reviewed
Aug 19, 2025
…-19_web-tooling-update
kmiller68
reviewed
Aug 26, 2025
| "prepack", | ||
| "uglify-js", | ||
| "esprima-next", | ||
| // "lebab", |
There was a problem hiding this comment.
Nit: We should probably comment as to why we're not running it anymore.
| BUNDLE: `./web-tooling-benchmark/dist/${name}.bundle.js`, | ||
| ...WPT_FILES, | ||
| }, | ||
| iterations: 15, |
There was a problem hiding this comment.
4 Worst Case counts out of 15 seems kinda high relative to other benchmarks with 15 iterations. All the others do 2 worst cases for 15 iterations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The orignal benchmark has been stale for a while and uses a more node-oriented build process.
Given the experience with the previous webpacked workloads I've decided to simply include the full sources and adapt and rewrite it.