Skip to content

Conversation

@esudalaimadan
Copy link
Contributor

@esudalaimadan esudalaimadan commented Jan 31, 2020

Fix #50, #121

@sudar

  1. please check against subdomains as I have checked only against subdirectories.
  2. When running as single site, multisite tests are running and failing.

@todo
Copy link

todo bot commented Jan 31, 2020

Do we need to log errors if there is any error?

https://github.com/sudar/bulk-delete/blob/31c2804b385797587bff29631869e4d7e252cd02/include/Core/Sites/Modules/DeleteSitesByNameModule.php#L83-L88


This comment was generated by todo based on a TODO comment in 31c2804 in #709. cc @sudar.

@esudalaimadan esudalaimadan requested a review from sudar January 31, 2020 05:34
@sudar
Copy link
Contributor

sudar commented Jan 31, 2020

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 2
           

Complexity increasing per file
==============================
- include/Core/Sites/SitesModule.php  4
- include/Core/Sites/Modules/DeleteSitesByNameModule.php  7
- include/Core/Users/DeleteUsersInMultisitePage.php  1
- tests/wp-unit/include/Core/Users/Modules/DeleteUsersByUserMetaInMultisiteModuleTest.php  6
- include/Core/Multisite/MultisiteAdminUIBuilder.php  3
- include/Core/Sites/DeleteSitesInMultisitePage.php  1
- include/Core/Users/UsersModule.php  2
- include/Core/Users/Modules/DeleteUsersByUserMetaInMultisiteModule.php  2
         

Clones added
============
- include/Core/Sites/SitesModule.php  1
         

See the complete overview on Codacy

*/
do_action( 'bd_before_query', $wp_site_query );

$sites = (array) $wp_comment_query->query( $options );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

// phpcs:ignore Squiz.Commenting.FunctionComment.Missing
protected function build_query( $options ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudar sudar added this to the 6.2.0 milestone Jul 2, 2020
@sudar sudar changed the base branch from dev/6.1.0 to dev/6.2.0 July 2, 2020 01:19
sudar and others added 18 commits July 2, 2020 07:16
Recently the way StyleCi parses configuration has been changed which was generating errors in config files that were working earlier. This commit fixes those errors.
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.15...4.17.19)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sudar Muthu <[email protected]>
…erm-modules

PR: Add cron settings to term modules.
PR: Fix User ID retrieval from email and exclude parameter check.
@esudalaimadan esudalaimadan assigned esudalaimadan and unassigned sudar Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to delete blogs in multi-site

3 participants