Proof of concept gcode comment section skip

[gb0101010101]

Wanted to get feedback on this proof of concept feature to add buttons that skip through gcode file by finding comment lines like "(Some gcode comment)". It adds additional buttons "<(S)" and "(S)>" to the gcode move area (desktop version only for now).

Does this seem worthwhile pursuing?

• It does work for me using a Fusion360 Malsow Post Processed gcode file.
• It only matches comments where open bracket is at beginning of line so will ignore inline comments.
• I also made it ignore "(MSG, *)" which is a gcode display message. (Is this even implemented in Webcontrol?)
• Are there any others comment formats that should be ignored e.g. "(LOG, log message)"?

Please do not commit this as it is not complete and just proof of concept.

[davidelang]

I believe that comments get stripped out of the g-code when it's loaded (the firmware can get confused by comments, so the 'quick fix' was not to send any to the firmware) David Lang

[madgrizzle]

Comments don't get stripped anymore when the file is loaded (the only thing that gets stripped are blank lines) but webcontrol does strip them, in real time, while sending them to the controller.

This could be a handy addition.

[madgrizzle]

I also made it ignore "(MSG, *)" which is a gcode display message. (Is this even implemented in Webcontrol?)

No, that's not implemented (first I've seen of that)

Are there any others comment formats that should be ignored e.g. "(LOG, log message)"?

None of those commands are implemented, so I'd leave it up to you if you want to skip them or not.

But overall, I like it very much. I merged your PR into a 'test' branch I made that had your UI-improvements merged, but the "(S)>" came out on its own line.

[gb0101010101]

the "(S)>" came out on its own line.
The buttons have a lot of left/right padding. I added temporary "moveButtons" class to the div.row that houses them and reduced it in CSS. Perhaps you missed that in the merge?

[madgrizzle]

Are you still working on this? I like the functionality of it.

[madgrizzle]

.. and what's your maslow forum handle so I know.. its hard to keep track of people when github name is different than the forum name.