Allow constructors to be fallible #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
approved these changes
Aug 7, 2025
badeend
added a commit
to badeend/wasm-tools
that referenced
this pull request
Aug 21, 2025
badeend
added a commit
to badeend/wasm-tools
that referenced
this pull request
Aug 21, 2025
badeend
added a commit
to badeend/wasm-tools
that referenced
this pull request
Aug 21, 2025
badeend
added a commit
to badeend/wasm-tools
that referenced
this pull request
Aug 21, 2025
github-merge-queue bot
pushed a commit
to bytecodealliance/wasm-tools
that referenced
this pull request
Aug 21, 2025
badeend
added a commit
to badeend/wit-bindgen
that referenced
this pull request
Aug 22, 2025
And C support came along for free. See: WebAssembly/component-model#550 C++, C# & Moonbit are not supported yet.
badeend
added a commit
to badeend/wit-bindgen
that referenced
this pull request
Aug 23, 2025
And C support came along for free. See: WebAssembly/component-model#550 C++, C# & Moonbit are not supported yet.
github-merge-queue bot
pushed a commit
to bytecodealliance/wit-bindgen
that referenced
this pull request
Aug 23, 2025
And C support came along for free. See: WebAssembly/component-model#550 C++, C# & Moonbit are not supported yet.
|
Alright, from #285, sounds like support for this has merged into tools, so I'll go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #285, this PR relaxes the validation rules for
[constructor]-annotated functions to additionally allow explicitly-declaredresult<r, ...>return types (e.g.,resource r { constructor() -> result<r>; }).