Skip to content

fix: async indicator in canon yield #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vados-cosmonic
Copy link
Collaborator

This commit fixes the variable name in the python code that seems to be referencing whether it's an async yield rather than a sync yield, but is written as 'sync'.

This commit fixes the variable name in the python code that seems to
be referencing whether it's an *async* yield rather than a *sync*
yield, but is written as 'sync'.

Signed-off-by: Victor Adossi <[email protected]>
@lukewagner
Copy link
Member

As a convention throughout the CABI (commented in CanonicalOptions), to avoid writing async_ everywhere, we use sync, so I'd prefer to do that consistently.

@vados-cosmonic
Copy link
Collaborator Author

Ah thanks for clarifying this -- will close his then!

@vados-cosmonic vados-cosmonic deleted the fix=async-indicator-in-canon-yield branch June 27, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants