Validate features when building shared types#8298
Merged
Conversation
Previously we would validate that some usages (e.g. globals) of shared types required the shared-everything feature, but that was not enough to prevent fuzzer issues because it was still possible to write a file that used shared types and passed validation without shared-everything, so would fail when fuzzed on V8. Fix the problem by validating features when building shared types in the first place.
kripken
approved these changes
Feb 11, 2026
tlively
commented
Feb 11, 2026
Member
|
This does not seem to have fixed the issue mentioned in The file parses without shared-everything, but it uses shared. |
Member
Author
|
Oh, right, sorry, because that's using a shared abstract heap type... |
tlively
added a commit
that referenced
this pull request
Feb 11, 2026
We started validating that shared-everything is enabled when we defined shared types in #8298, but this missed the case where a non-shared type definition used a shared abstract heap type, which has no definition. Update the validation to check that the used types are allowed by the enabled feature set as well. Refactor the validation logic into several functions to avoid duplication of logic.
tlively
added a commit
that referenced
this pull request
Feb 12, 2026
We started validating that shared-everything is enabled when we defined shared types in #8298, but this missed the case where a non-shared type definition used a shared abstract heap type, which has no definition. Update the validation to check that the used types are allowed by the enabled feature set as well. Refactor the validation logic into several functions to avoid duplication of logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would validate that some usages (e.g. globals) of shared
types required the shared-everything feature, but that was not enough
to prevent fuzzer issues because it was still possible to write a file
that used shared types and passed validation without shared-everything,
so would fail when fuzzed on V8. Fix the problem by validating features
when building shared types in the first place.