Disable relaxed atomics for v8 tests in the fuzzer #8199
Merged
+17
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| CLOSED_WORLD_FLAG = '--closed-world' | ||
|
|
||
| DISALLOWED_FEATURES_IN_V8 = ['shared-everything', 'strings', 'stack-switching', 'relaxed-atomics'] |
Member
Author
There was a problem hiding this comment.
The other two files here set --disable-fp16, should that be here too?
Member
There was a problem hiding this comment.
Good question. @brendandahl do you know the status of fp16 support in v8, or who to ask?
Collaborator
There was a problem hiding this comment.
V8 supports the whole current proposal and nothing has changed recently that I know of. However, the future of the proposal is still up in the air, so I'm not sure we should be fuzzing yet. Maybe @dtig has thoughts?
stevenfontanella
changed the title
kripken
reviewed
Jan 13, 2026
kripken
reviewed
Jan 13, 2026
kripken
reviewed
Jan 13, 2026
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm % last comment
We can decide on fp16 in a separate PR, to keep this one narrow.
kripken
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #8169. Fixes the fuzzer which currently generates code with --enable-relaxed-atomics which isn't supported in v8. To test, I ran the fuzzer successfully for ~20 minutes locally.
Part of #8165.
In the future, we'll also add fuzzing support for relaxed atomics by generating acqrel instructions.