Only generate AcqRel SafeHeap load methods when --relaxed-atomics is enabled #8193
+26
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenfontanella
force-pushed
the
safeheap-fix
branch
from
f750642 to
bf95dd4
Compare
stevenfontanella
force-pushed
the
feature-flag
branch
from
2f0fc13 to
23f7811
Compare
stevenfontanella
force-pushed
the
safeheap-fix
branch
from
bf95dd4 to
a509931
Compare
kripken
approved these changes
Jan 10, 2026
tlively
approved these changes
Jan 10, 2026
stevenfontanella
added a commit
that referenced
this pull request
Jan 11, 2026
Part of #8165. Add flag for --enable-relaxed atomics and enable it for the existing SafeHeap tests that previously implicitly depended on it. The next PR #8193 disables generation of AcqRel SafeHeap functions when the feature is disabled and adds new tests to cover that case. Also validate that the feature is enabled when a module includes an AcqRel load operation (currently the only one we support).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new tests don't contain the string
ARoracqrelfor the atomic load methods that are generated. Note that the safe load function names are still changed compared to before #8169 but I assume that no-one else relies on the names that we pick. Part of #8165.