Skip to content

Remove subscription_t's clock.identifier field. #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Remove subscription_t's clock.identifier field. #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions phases/ephemeral/witx/typenames.witx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,8 +552,6 @@
;; The contents of a $subscription_t when type is `EVENTTYPE_CLOCK`.
(typename $subscription_clock_t
(struct
;; The user-defined unique identifier of the clock.
(field $identifier $userdata_t)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may theoretically be useful for debuggers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would it add beyond the clock_id field?

Copy link

@bjorn3 bjorn3 Oct 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though I read that it was a string. In that case, a debugger could show that string to the user. I think it would be better to design such debugger integrations separately and for all things it makes sense for at a later time though.

;; The clock against which to compare the timestamp.
(field $clock_id $clockid_t)
;; The absolute or relative timestamp.
Expand Down