Refactor/to-scss-reveal-content-container #251
+21
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webdevpathstage ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cherylli
reviewed
Jul 10, 2025
|
|
||
| const RevealContentContainer = ({ children }) => { | ||
| const [ref, entry] = useIntersect({}); | ||
| const [firstLoad, setFirstLoad] = useState(true); | ||
| const [hiddenStyle, setHiddenStyle] = useState(true); | ||
| const hiddenStyleClass = hiddenStyle ? styles.sectionHidden : null; // return sectionHidden class name if hiddenStyle is true. |
There was a problem hiding this comment.
We can remove this comment. It's not necessary to add comments to self-explanatory code as people reading the code are usually also developers
Another issue with this line is if it's set to null, it will has class="null" in the html like so
There was a problem hiding this comment.
Hi @cherylli ! Thanks for the review. I've fix the null set on class name, and remove the unnecessary comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you updated the CHANGELOG.md file? If not, please do it.
Yes
What is this change?
RevealContentContainercomponent from styled-components to SCSS module.Were there any complications while making this change?
None
How to replicate the issue?
N/A
If necessary, please describe how to test the new feature or fix.
Reload browser or scroll down to check first load transitions.
When should this be merged?
After the reviews.
Image Reference
Not available since it's non-static update. It's the transition from first load.