xgameprotocol: add stubs#31
Open
LukasPAH wants to merge 1 commit into
Open
Conversation
olivi-r
reviewed
Apr 30, 2026
Contributor
olivi-r
left a comment
olivi-r
left a comment
There was a problem hiding this comment.
XGameProtocolActivationCallback is a caller defined function passed to XGameProtocolRegisterForActivation
Comment on lines
+71
to
+75
| static void WINAPI x_gameprotocol_XGameProtocolActivationCallback(IXGameProtocolImpl *iface, void *context, const LPSTR protocolUri) | ||
| { | ||
| FIXME("iface %p, context %p, protocolUri %p stub!\n", iface, context, protocolUri); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| static void WINAPI x_gameprotocol_XGameProtocolActivationCallback(IXGameProtocolImpl *iface, void *context, const LPSTR protocolUri) | |
| { | |
| FIXME("iface %p, context %p, protocolUri %p stub!\n", iface, context, protocolUri); | |
| } |
| /* IXGameProtocolImpl methods */ | ||
| x_gameprotocol_XGameProtocolRegisterForActivation, | ||
| x_gameprotocol_XGameProtocolUnregisterForActivation, | ||
| x_gameprotocol_XGameProtocolActivationCallback, |
Contributor
There was a problem hiding this comment.
Suggested change
| x_gameprotocol_XGameProtocolActivationCallback, |
| { | ||
| HRESULT XGameProtocolRegisterForActivation( [in] XTaskQueueHandle queue, [in] void *context, [in] void *callback, [out] XTaskQueueRegistrationToken *token ); | ||
| BOOLEAN XGameProtocolUnregisterForActivation( XTaskQueueRegistrationToken *token, boolean wait ); | ||
| void XGameProtocolActivationCallback( [in] void *context, [in] LPSTR protocolUri ); |
Contributor
There was a problem hiding this comment.
Suggested change
| void XGameProtocolActivationCallback( [in] void *context, [in] LPSTR protocolUri ); |
| ] | ||
| interface IXGameProtocolImpl : IUnknown | ||
| { | ||
| HRESULT XGameProtocolRegisterForActivation( [in] XTaskQueueHandle queue, [in] void *context, [in] void *callback, [out] XTaskQueueRegistrationToken *token ); |
Contributor
There was a problem hiding this comment.
Suggested change
| HRESULT XGameProtocolRegisterForActivation( [in] XTaskQueueHandle queue, [in] void *context, [in] void *callback, [out] XTaskQueueRegistrationToken *token ); | |
| HRESULT XGameProtocolRegisterForActivation( [in] XTaskQueueHandle queue, [in] void *context, [in] XGameProtocolActivationCallback *callback, [out] XTaskQueueRegistrationToken *token ); |
| typedef struct XSystemAnalyticsInfo XSystemAnalyticsInfo; | ||
| typedef struct XTaskQueueObject* XTaskQueueHandle; | ||
| typedef struct XTaskQueueRegistrationToken XTaskQueueRegistrationToken; | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| typedef void __stdcall XGameProtocolActivationCallback( void* context, const char *protocolUri ); | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some stubs for XGameProtocol (https://learn.microsoft.com/en-us/gaming/gdk/docs/reference/system/xgameprotocol/xgameprotocol_members?view=gdk-2510).
Minecraft GDK builds make an early call to XGameProtocolRegisterForActivation during startup and assert/crash on non-publish (i.e. partner) versions if the HRESULT isn't S_OK. Same deal for XGameProtocolUnregisterForActivation when closing the game if the result isn't true/false.
LMK if changes are needed since they are pretty quick and dirty stubs.