Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make road type choices exclusionary #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LihtsaltMats
Copy link
Contributor

#47

Replaces the multiple choice checkboxes with radio buttons
image

It will hide the road type radio buttons if the main checkbox is unchecked so that we'd use the same style as with "Add road type buttons".

For (hopefully) seamless migration I changed the order of the settings so if someone had both checkboxes checked it will read the city name setting last and it will be ticked.

Copy link
Member

@mapomatic mapomatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. The existing format has always bugged me. Actually started a branch to turn them into a dropdown select instead of two checkboxes, but didn't get very far with it.

We'll need to account for people that don't want to do either of those things, i.e. just leave the street/city alone. I had envisioned a checkbox for "Set street to none" and a dropdown with options for "Set city to None" and "Set city to connected seg's city". The dropdown would be disabled if the checkbox wasn't ticked. I'm open to other ideas though, e.g. a checkbox and two radio buttons, or something else.

@LihtsaltMats
Copy link
Contributor Author

I currently kept the choice compulsory, because I couldn't think of a use case when adding an unconfirmed road is acceptable. So my thinking was that the script shouldn't be creating them either.

If that's a proper use case then radio buttons should be swapped with a dropdown with an empty option as well. Three radio options gets a bit crowded. Although... Ironically for "ClickSaver" it would require an extra click.

@mapomatic
Copy link
Member

The use case is if a user prefers to manually set the address instead of having the script do it. If they accidentally leave the address blank, the road appears red and they're reminded to fix it. I think some people will be upset if the script forces an address change for all of those road types.

I agree that 3 settings starts to feel crowded. That's why I was thinking of a checkbox and a dropdown. But a single dropdown with all 3 options would work too. And that might even be a little easier to comprehend than a checkbox + dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants