Compilation time improvements (part 2) #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for mesonbuild/meson#4350 This does not work with all C++ compilers and is "use at own risk", therefore disabled by default. Can be enabled by passing `-Dcustom_pch=true` to meson. When disabled, it should not affect anything. Speeds up compilation by at least 20% in local tests (48s vs 38s).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for PCH in plugins.
Mostly it is a workaround for mesonbuild/meson#4350.
This does not work with all C++ compilers and is "use at own risk", therefore disabled by default. Can be enabled by passing
-Dcustom_pch=trueto meson. When disabled, it should not affect anything.Speeds up compilation by at least 20% in local tests (48s vs 38s in plain build, 1m54s vs 1m40s in debugoptimized+asan).