Allow Vendored Configuration File #2588
Conversation
This PR adds support for vendoring the Wayfire configuration file. In
particular this means `${XDG_CONFIG_HOME}/wayfire/wayfire.ini` will take
precedence over `${XDG_CONFIG_HOME}/wayfire.ini` while looking for a
configuration file.
I opted to implement this change, since Wayfire already uses
vendor-directories for plugin data in `${XDG_DATA_HOME}/wayfire/plugin`.
Furthermore, I spent way too long trying to find out why my default
configuration is not working. I assume this change can reduce the
maintenance burden, since people doing the same mistake will not open an
issue or ask in IRC.
I copied it from `/usr/share/examples/wayfire/wayfire.ini` as packaged
by my distro and therefore assumed wayfire uses the common vendor prefix
pattern. While researching my problem, I found several threads where
people likely did the same mistake.
|
As an alternative approach, I'd love to add a log message, when |
|
The CI is failing because some files I did not touch are not formatted properly. Should I format and commit those as well? |
We use patched uncrustify to workaround some bugs. Look more closely at the CI output the command before the failed check tells you what you need to fix (spoiler: it is a file you did change :)). |
Oh noooo that's embarrassing lol let me rerun uncrustify right quick :D |
This PR adds support for vendoring the Wayfire configuration file. In particular this means
${XDG_CONFIG_HOME}/wayfire/wayfire.iniwill take precedence over${XDG_CONFIG_HOME}/wayfire.iniwhile looking for a configuration file.I opted to implement this change, since Wayfire already uses vendor-directories for plugin data in
${XDG_DATA_HOME}/wayfire/plugin. Furthermore, I spent way too long trying to find out why my default configuration is not working. I assume this change can reduce the maintenance burden, since people doing the same mistake will not open an issue or ask in IRC.I copied it from
/usr/share/examples/wayfire/wayfire.inias packaged by my distro and therefore assumed wayfire uses the common vendor prefix pattern. While researching my problem, I found several threads where people likely did the same mistake.