Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scaling only the windows of the focused app #2134

Closed
wants to merge 1 commit into from

Conversation

lcolitti
Copy link
Contributor

This adds support to the scale plugin to show only the windows of a given app (or of a given app on all workspaces). This is similar to the compiz feature that scales only the windows of a window group.

This adds support to the scale plugin to show only the windows
of a given app (or of a given app on all workspaces). This is
similar to the compiz feature that scales only the windows of a
window group.
@ammen99
Copy link
Member

ammen99 commented Feb 11, 2024

Duplicate of #1911

Unfortunately, my stance on this hasn't changed.

Thanks for your PR nonetheless :)

@ammen99 ammen99 closed this Feb 11, 2024
@ammen99
Copy link
Member

ammen99 commented Feb 11, 2024

Here is the functionality as a standalone plugin, I think you should easily be able to get this working with an ipc script bound to a hotkey.https://github.com/dkondor/wayfire-scale-ipc

@soreau
Copy link
Member

soreau commented Feb 11, 2024

I'm not sure if this is what you're looking for but there is a window-zoom plugin in wayfire-plugins-extra.

@lcolitti
Copy link
Contributor Author

I get that this is possible to do with an out-of-tree plugin (and thanks for the link), but why require users to do that? The fact that several people have asked for this suggests it's a useful feature. Mac OS has it, and compiz does as well (or did before apparently it broke). Why not include it? It doesn't seem to be a lot of work to maintain.

FWIW what I am trying to do here is not write code for a specific dock, it's just to improve the user experience of using wayfire and wf-panel. My use case is: I always have dozens of windows open on lots of workspaces, because I use multi-window setups in all apps. I want to pick a window visually from the app I'm already using. Say I'm working on scale.cpp and want to switch to the .hpp file. I know it's another text editor window, but I don't know where it is because its obscured by other windows from other apps (e.g., browsers open at C++ documentation). If I use scale without filters I probably won't be able to pick the window among the dozens of windows I have open - I can see which windows are text editors, but I can't see the one I want because the text in them is too small to read. With this keybinding I can find the window I want.

Sure, it may not be something that most users need. But again - why not support it? Is there a downside?

@ammen99
Copy link
Member

ammen99 commented Feb 13, 2024

Sure, it may not be something that most users need. But again - why not support it? Is there a downside?

The downside is that this repo gets bigger and bigger. I understand the motivation for this particular feature, but this is about the general principle - there are tons of small features which would make sense, but if you put them together, Wayfire's main repo will become too large. This means that basically all features which can be easily delegated to a third-party plugin and I don't deem crucial for the project (or are necessary as a demo of a functionality) are left as an exercise for the reader :)

I myself am using a few external plugins: https://github.com/ammen99/wayfire-plugins

Note that my vision for the project from the very start has been users using multiple plugins from different places. So I don't see this as a downside. I agree that we ought to make installing plugins easier - see #1912.

@ammen99
Copy link
Member

ammen99 commented Feb 13, 2024

Also note that, if contributors/Wayfire plugin authors feel like this is a suboptimal way of doing things, nothing prevents people from creating one mega-reposjtory with all kinds of plugins written by various plugins authors. Think of wayfire-plugins-extra for example :)

@soreau
Copy link
Member

soreau commented Feb 13, 2024

This adds support to the scale plugin to show only the windows of a given app (or of a given app on all workspaces). This is similar to the compiz feature that scales only the windows of a window group.

It seems like you can get the same job done with scale title filter plugin, in addition to scale. This way, you can type and match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants