refactor code #43
Open
refactor code #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
兄弟 双击最大/最小那里写反了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first encountered PyQt, your project dazzled me, but I wasn't sure how to apply it. Today, after using PyQt for about a year, I've come to realize that the code style seems similar to JavaScript. Therefore, I decided to refactor the code, maintaining the same functionality while reshaping it with a more Pythonic style. Going forward, I hope that these changes, coupled with your open-source and well-designed QSS layouts, simple, and elegant animations, can assist more people in using it. Overall, there seems to be an excessive use of inheritance in the code, leading to some complexity."